Don't publish examples to npm

algolia / gatsby-plugin-algolia

A plugin to push to Algolia based on graphQl queries

https://yarn.pm/gatsby-plugin-algolia

Apache License 2.0

178 stars 45 forks source link

Don't publish examples to npm #31

Closed sidharthachatterjee closed 5 years ago

sidharthachatterjee commented 5 years ago

As of gatsby@2.12.1 (https://github.com/gatsbyjs/gatsby/pull/15284), we now parse GraphQL queries in dependencies to enable packages to ship queries!

The examples in this repo however interfere with this and cause this package to break (details in https://github.com/gatsbyjs/gatsby/issues/15344)

We highly recommend not shipping examples to npm and this PR fixes this by adding it to .npmignore

Cheers from the gatsby team!

Haroenv commented 5 years ago

Thanks @sidharthachatterjee! We usually use files in package.json though. Can you change it to include just gatsby-node.js there? If it's too much work I can also do it myself

sidharthachatterjee commented 5 years ago

Thank you for the quick response, @Haroenv! I've removed .npmignore and added files instead 🙌

Haroenv commented 5 years ago

published 0.3.1 with this :)