search

algolia / gatsby-plugin-algolia

A plugin to push to Algolia based on graphQl queries
https://yarn.pm/gatsby-plugin-algolia
Apache License 2.0
178 stars 45 forks source link

The main `settings` is not applied #64

Closed eunjae-lee closed 4 years ago

eunjae-lee commented 4 years ago

~Unlike query.indexName, query.settings doesn't override the main settings. Is it intended?~

Haroenv commented 4 years ago

You closed this now, is it a bug or not? :)

eunjae-lee commented 4 years ago

The title and the description were wrong 😅 So what happened is, 

{
  resolve: 'gatsby-plugin-algolia',
  options: {
    appId,
    apiKey,
    indexName,
    queries,
    settings,
  },
},

That settings doesn't work. For me to update the settings, I had to specify it in query.settings. I don't think that main settings is passed to getSettingsToApply.

Haroenv commented 4 years ago

It's too bad I didn't find a way to add tests to this repo yet, otherwise this would be easy to prove with a new test

Haroenv commented 4 years ago

fixed in 0.11.0