Update the API client version

algolia / github-awesome-autocomplete

:octocat: Add instant search capabilities to GitHub's search bar

https://github.algolia.com

Other

1.07k stars 93 forks source link

Update the API client version #30

Closed seafoox closed 7 years ago

seafoox commented 8 years ago

For now the extension is using an old version of the JS API client. That one doesn't include the DSN logic required in case of DNS issue.

var ALGOLIA_VERSION = '2.8.5';

redox commented 8 years ago

Yes we should move to v3; I'm just a bit afraid of the Firefox's extension validation process -> last time they read all the code and I manually needed to remove the JSONP-related snippet of code for security reason.

redox commented 8 years ago

See https://github.com/algolia/github-awesome-autocomplete/blob/master/code/js/libs/algoliasearch.js#L627-L636

rayrutjes commented 7 years ago

I think we should not do the move for now. It would indeed be a problem for the different market places. Maybe with the client in V4 we could just include the strict minimum required that would not raise an alert during the reviewing processes on the different marketplaces.