search

algolia / github-awesome-autocomplete

:octocat: Add instant search capabilities to GitHub's search bar
https://github.algolia.com
Other
1.07k stars 93 forks source link

Does not work after having filtered on a language #38

Closed rayrutjes closed 7 years ago

rayrutjes commented 8 years ago

When on a repository search page, if we filter by language, the search is reloaded asynchronously which breaks the bindings.

Maybe we could delegate the binding to a higher level in the dom tree?

image

redox commented 8 years ago

Hmmm, good catch :/

But what should we do since we don't have the data to provide a faceted search based on the language :/ Breaking the binding is now good, but I'm wondering if we want to show the dropdown menu to the user once he selected a language :/

rayrutjes commented 8 years ago

You are right. I think breaking the binding makes sense actually as we do not have the language as a facet. Feel free to close.