Closed eromoe closed 6 years ago
Hey @eromoe ,
Thanks for reaching out.
Is it this part you want to change?
This feature mimics the default GitHub behaviour.
If you press the return button multiple times however it will remove the current repository
scope.
Let me know if that is not what you meant.
@rayrutjes
I mean provide a config option change
to
Maybe a dropdown list :
and user can config the default order .
I think I see what you mean. You are searching for a repo, but don't find a suitable answer in the autocompleted results then you want to submit the request globally and not to the repo only.
I think that makes sense and best would probably be to add a suggestion a second choice of the dropdown.
I don't think we will add "options" for now because it requires more setup but definitely something we could do in the future.
@eromoe what do you think of #70 ? Was that what you had in mind?
A little different ,
Right click github-awesome-autocomplete
icon
the second grey out menu item is option.
I would feel better to go into option and choose the behavious of the search box in a repository.
Default behavious is like you PR
this repository
in front of search boxBut one can change default behavious to
this repository
in front of search box (default search all repo)I want this because I barely use "search xxx in this repo" . I usually prefer clone a repo , search keyword and view detail in a IDE.
Hey @eromoe ,
I think that this feature alone does not justify the additional dedicated options page.
Also, our initial idea here was that the default "enter" mimics the GitHub behaviour. If you want to search globally you could also always start by removing the "This repository" label.
I'll leave this open here to see if more users are interested.
Solved by #76 .
Hello
I usually not tend to search keyword in
this repository
while I am in a repo.For example, I am in
github-awesome-autocomplete
report this feature request, and then I want to search github notification enhance , I have to click github home icon to home page to do the search.