feat(autocomplete): add an option to search globally instead of in repo

algolia / github-awesome-autocomplete

:octocat: Add instant search capabilities to GitHub's search bar

https://github.algolia.com

Other

1.07k stars 93 forks source link

feat(autocomplete): add an option to search globally instead of in repo #70

Closed rayrutjes closed 6 years ago

rayrutjes commented 7 years ago

Closes: #69

This adds an option to search everywhere instead of in the current repository.

Jackymancs4 commented 6 years ago

Hello @rayrutjes Any plan on merging this? Since it's definitely a nice feat and something I would use!

rayrutjes commented 6 years ago

I'm not convinced about this PR @Jackymancs4 . It seems like you can easily delete the current repository context by hitting the return key.

I do realize this PR is convenient when you already typed something and you want to search in all repositories, but I don't want it to affect all other users that would now have to hit the arrow down key once more to get to their result.

Jackymancs4 commented 6 years ago

I see. Well, it's a good point.. Would you mind to take a look at #76? I think it works pretty well, and the whole feature (in a way or another) greatly improve my workflow.

Haroenv commented 6 years ago

An idea is to put in on the arrow up key:

input
	search in all repos
x	search in this repo
result 1
result 2
result 3
result 4

People will still have the key order they expect, and it will be simple to search in all repos.

The other option (I think already mentioned) would be to backspace if your cursor is at the first position to switch, like the real GitHub search behaviour.

rayrutjes commented 6 years ago

Solved by #76 .