search

algolia / hn-search

Hacker News Search
http://hn.algolia.com
Other
549 stars 74 forks source link

Comments with null points and different order than HN #206

Open ig-perez opened 3 years ago

ig-perez commented 3 years ago

Hi,

Thanks for maintaing this repo. I have noticed comments from a given item return with points: null, probably this is causing the comments are not returned in the same order as when querying HN. For example:

https://hn.algolia.com/api/v1/items/26750452 https://news.ycombinator.com/item?id=26750452

Thanks

pierregoutheraud commented 2 years ago

Is this project still maintained? Sorting comments by popularity is still broken :'(

JonasBa commented 2 years ago

cc @Haroenv anyone that could take a look at this?

julienpa commented 2 years ago

Hi @ig-perez @JonasBa, the issue in the initial comment seems to be fixed (both link show the same number of points).

@pierregoutheraud could you elaborate? Do you have an example where it's not working? Selecting "Comments" and leaving the default sorting "Popularity" seems to work (tried searching as well): All Search powered by Algolia 2022-09-27 at 11 58 36 AM

ig-perez commented 2 years ago

Cool, thanks @julienpa . @pierregoutheraud feel free to close the issue if works for you as well.

Best, Ivan

pierregoutheraud commented 2 years ago

@julienpa When sorting comments by popularity "All time" time range works but any other time range returns the same results:

https://user-images.githubusercontent.com/1341781/193686106-3559a260-bccd-4a67-979b-b4af5ae5f2d7.mov

This might be because hackernews api does not return the score for comments anymore.