search

algolia / instantsearch-core-swift

⚡️ InstantSearch Core library for Swift and Objective-C
https://community.algolia.com/instantsearch-core-swift/
Apache License 2.0
18 stars 10 forks source link

Building via SwiftPM for Catalyst using Xcode 11.4 beta fails #103

Closed rhettdickson closed 4 years ago

rhettdickson commented 4 years ago

Describe the bug 🐛 Attempting to build an Xcode project with instantsearch-core-swift added as a Swift package using Xcode 11.4 beta for Catalyst fails due to usage of CoreTelephony symbols

To Reproduce 🔍 Steps to reproduce the behavior:

  1. Install latest Xcode 11.4 beta
  2. Create a new iOS Xcode project, enable Catalyst (click Mac checkbox in target's General settings)
  3. Add instantsearch-core-swift to packages via swiftpm
  4. Build for macOS target

Expected behavior 💭 Build succeeds

Actual behavior

Build fails with: .../SourcePackages/checkouts/algoliasearch-client-swift/Sources/AlgoliaSearch-Client/Network.swift:95:31: Use of unresolved identifier 'CTTelephonyNetworkInfo'

Screenshots 🖥

image

Environment:

VladislavFitz commented 4 years ago

Hi @rhettdickson Thank you for reporting this. The patch 7.0.4 of InstantSearch Client (a dependency of InstantSearch Core) which has just been released fixes this failure. Update your SPM dependencies to have the issue resolved.