Closed VladislavFitz closed 1 year ago
@VladislavFitz
I found a minor issue on one of the constructor where the jsonDecoder parameter value is not passed.
convenience public init(infiniteScrolling: InfiniteScrolling = Constants.Defaults.infiniteScrolling,
showItemsOnEmptyQuery: Bool = Constants.Defaults.showItemsOnEmptyQuery,
jsonDecoder: JSONDecoder = JSONDecoder()) {
let settings = Settings(infiniteScrolling: infiniteScrolling,
showItemsOnEmptyQuery: showItemsOnEmptyQuery)
self.init(settings: settings)
// Expected
// self.init(settings: settings, jsonDecoder: jsonDecoder)
}
Great catch @steffidg , the fix is on its way 👌
Is your feature request related to a problem? Please describe 🙏
Described here. Client wants the
Codable
model variable names to be in camel case.HitsInteractor
supports only the snake case since it uses the defaultJSONDecoder
constructor, so the client might addCodingKeys
per model.Describe the solution you'd like 🤔 Add possibility to set a custom
JSONDecoder
property toHitsInteractor
responsible for search hits decoding.