search

algolia / instantsearch-ios

⚡️ A library of widgets and helpers to build instant-search applications on iOS.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/ios/
Apache License 2.0
591 stars 55 forks source link

The app references non-public selectors `didToggleSwitch` and `didSelectSegment` warning when uploading to AppStore Connect #280

Closed qizh closed 7 months ago

qizh commented 1 year ago

Sometimes I get the following warning when uploading my app:

AppStore Connect upload complete screenshot

The only places where such selectors are referenced in my code base are coming from your library.

https://github.com/algolia/instantsearch-ios/blob/09c9fa3c762064b005fb4bb56b9f28b426b77b62/Sources/InstantSearch/Selectable/FilterSwitchController.swift#L24

https://github.com/algolia/instantsearch-ios/blob/09c9fa3c762064b005fb4bb56b9f28b426b77b62/Examples/Showcase/Filter/FilterList/MainViewController.swift#L41

I believe this is an Apple's bug. Though I think it would be great from your side to update your code so it doesn't reference selectors with names similar to Apple private ones.

https://github.com/algolia/instantsearch-ios/blob/09c9fa3c762064b005fb4bb56b9f28b426b77b62/Sources/InstantSearch/Segmented/SegmentedController.swift#L40

https://github.com/algolia/instantsearch-ios/blob/09c9fa3c762064b005fb4bb56b9f28b426b77b62/Sources/InstantSearch/Selectable/FilterSwitchController.swift#L27

qizh commented 7 months ago

This was Xcode or App Store Connect issue which was resolved.