algolia / instantsearch-ios

⚡️ A library of widgets and helpers to build instant-search applications on iOS.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/ios/
Apache License 2.0
591 stars 55 forks source link

Breaking changes in dependencies #305

Open squarefrog opened 5 months ago

squarefrog commented 5 months ago

Describe the bug 🐛 Originally reported in algoliasearch-client-swift but it feels more relevant here. Feel free to close that issue if you like.

One of instantsearch-ios dependencies has introduced a breaking change that prevents instantsearch-ios from building on iOS 15. It bumps the minimum target to iOS 14, but instantsearch-ios has a minimum target of iOS 9. This prevents compilation, even if you are targeting a higher version than iOS 9.

To Reproduce 🔍 Steps to reproduce the behavior:

  1. Clone this project
  2. Open the Example Xcode project
  3. Wait for package resolution
  4. Attempt to build

Expected behavior 💭 Example project should build.

Screenshots 🖥

Screenshot 2024-02-02 at 15 42 58

Environment:

Additional context You can work around this issue by manually adding https://github.com/algolia/algoliasearch-client-swift to your project, and setting the resolution rule to be exact: 8.19.0

Screenshot 2024-02-02 at 15 44 54
VladislavFitz commented 5 months ago

Hi @squarefrog , That's indeed an unexpected breaking change. Thanks for flagging this! We're preparing an update for InstantSearch iOS to fix it. Expect a release soon. Meanwhile, your workaround with the explicit client version setting is a good interim solution.

squarefrog commented 5 months ago

Sounds good!

r3econ commented 4 months ago

Hi @VladislavFitz when would the fix go live? Our CI workflows fail with the above-mentioned error

RebinX1 commented 3 months ago

hi is there a fix for this yet?

Ma7m0udalaa commented 3 months ago

Any update for this?

salami commented 3 months ago

Also waiting on a fix for this

r3econ commented 2 months ago

Any update? We'd love to have it fixed :)

akshaaatt commented 1 month ago

Any update on this?

r3econ commented 1 month ago

@nickvlku any chance having this fixed? 🥲