search

algolia / instantsearch-ios

⚡️ A library of widgets and helpers to build instant-search applications on iOS.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/ios/
Apache License 2.0
591 stars 55 forks source link

Removing Logging from dependences makes build failures #306

Open IslamAbdelAziz opened 4 months ago

IslamAbdelAziz commented 4 months ago

Describe the bug 🐛 And when try to build the App, It shows an error that logging is missed in this file

To Reproduce 🔍 Steps to reproduce the behavior:

When I hit pod install for instant search I does install the SDK wiht these versions

Installing AlgoliaSearchClient 8.20.0 (was 8.18.0)

Installing InstantSearch 7.26.1 (was 7.13.3)

Installing InstantSearchTelemetry (0.1.3)

Installing SwiftProtobuf (1.25.2)

Removing Logging

Expected behavior 💭 has a successful build

Screenshots 🖥

Screenshot 2024-02-10 at 6 57 09 PM Screenshot 2024-02-10 at 6 56 28 PM Screenshot 2024-02-10 at 6 56 18 PM

Environment:

m4p commented 4 months ago

Same, but with SPM. My build is broken.

shay-situation commented 3 months ago

same with pods, any solution?

IslamAbdelAziz commented 3 months ago

We fixed it by setting specific versions for

pod 'AlgoliaSearchClient', '8.18.2'

This may fix the issue ISA

erolando commented 2 months ago

some news?