search

algolia / instantsearch-specs

CSS library for InstantSearch libraries
https://instantsearchjs.netlify.app/specs/
5 stars 4 forks source link

fix(pagination): adjust pagination item spec #119

Closed sarahdayan closed 2 years ago

sarahdayan commented 2 years ago

This updates the spec for pagination item classes.

The ais-Pagination-item--page and ais-Pagination-item--selected modifiers shouldn't be mutually exclusive. Having ais-Pagination-item--page on all numeric items is useful because it lets you identify them (otherwise there's no way to differentiate between them and "First"/"Previous"/"Next"/"Last".

This is already how the InstantSearch.js pagination (and upcoming <Pagination> in RISH) is implemented. For reference, none of the InstantSearch flavors implement the spec the same way.

Haroenv commented 2 years ago

The netlify build is old and needs an updated node/ubuntu. Looking into it

Haroenv commented 2 years ago

netlify works again, feel free to merge @sarahdayan