search

algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.66k stars 514 forks source link

refinementList: limit should be 1000 by default #155

Closed vvo closed 8 years ago

vvo commented 8 years ago

Current refinementList limit is always 100 which will lead to incomprehension, we should show all the facet values by default since the limit is already in the API server: 1000

So basically if no limit is passed there's nothing to do we just use the index settings. If a limit is passed then we limit it programmatically after receiving the data.

redox commented 8 years ago

Hmmm, I would rather go for 10 :) It doesn't make sense to display too much values. Also, what could be cool would be to set the maxValuesPerFacet query parameter to max(all limit options).

vvo commented 8 years ago

It doesn't make sense to display too much values.

agree but I prefer the user to see that there's a lot of values and he then has to limit it if he wants to. Rather than having himself thinking there's a bug somewhere because he cannot see all the values.

redox commented 8 years ago

Yes OK, that makes sense.

agwisniewska commented 1 year ago

Hi @vvo ?

I guess I'm experiencing an issue with this, take a look at the screenshots please:

Screenshot 2023-03-02 at 13 34 48 Screenshot 2023-03-02 at 13 34 57 Screenshot 2023-03-02 at 13 34 23

As you can see I have the list of country_iso as my facet values, and there are around 200 countries, so I set this limit, but all I can see both in the dashboard plus on the UI side (with Vue InstantSearch lib) is 100 values.

Did I miss something?