search

algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.59k stars 504 forks source link

explicitly set foreground color on searchbox #5189

Open Haroenv opened 5 years ago

Haroenv commented 5 years ago

see https://github.com/algolia/instantsearch.js/issues/3075

We explicitly set the background color to white; but we should not do that without also changing the foreground color. We have two options:

  1. don't set the background color, since the default is white
  2. set the foreground color to black

With option 2, and the status quo we don't play that well with dark themes, unless they do a color shift.

Haroenv commented 5 years ago

the consensus in algolia/instantsearch.js#3075 is to add color: black to the input

sarahdayan commented 1 year ago

I think the next step is to author a dark mode version of our themes based on prefers-color-scheme (which should work with GTK).

We can sort out the details later, but we could provide each scheme separately if the impact on bundle size is too big.