algolia / instantsearch

⚑️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.74k stars 527 forks source link

Installation problem: Property 'MarkerOptions' does not exist on type 'typeof maps'' #6253

Closed Annoxis closed 3 months ago

Annoxis commented 5 months ago

πŸ› Current behavior

I get the following error at instantsearch.js/es/widgets/geo-search/geo-search.d.ts:213:63 : Property 'MarkerOptions' does not exist on type 'typeof maps'. Here is the faulty line of code: markerOptions: GeoSearchMarker<typeof google.maps.MarkerOptions | Partial<HTMLMarkerArguments>>;

Removing "typeof" fixes the issue as a workaround for development, but it won't be applicable in production.

πŸ” Steps to reproduce

Simply download the relevant libraries, start a basic angular project and attempt to launch the front end. I am sorry, I have not been able to run the codesandbox online, but it worked locally.

Live reproduction

https://codesandbox.io/p/github/Annoxis/instantsearch_googlemaps_import_problem/main

πŸ’­ Expected behavior

My front end compile.

Package version

Instantsearch.js 4.72.2, types/google.maps 3.55.10, angular 15.2, npm 10.5.0

Operating system

Tested under Mac Sonoma and Windows 11 (WSL 2)

Browser

Irrelevant

Code of Conduct

Haroenv commented 5 months ago

Your sandbox seems to be private, but I tried to reproduce and I don't see an error: https://codesandbox.io/p/sandbox/friendly-ben-jzt2xs?file=%2Fsearch.ts%3A100%2C1-111%2C6

Annoxis commented 5 months ago

@Haroenv I updated the codesandbox, it should work now. The main difference between our codes is that I am using Angular and you are not.

KennethHoff commented 3 months ago

I can attest to this. It does not compile for me either.

antoniobuyukluev commented 3 months ago

Same on my end

Haroenv commented 3 months ago

I wonder if this is caused by somehow you having both @types/googlemaps and @types/google.maps installed. Can you check that? And if removing one of the two manually works

antoniobuyukluev commented 3 months ago

I wonder if this is caused by somehow you having both @types/googlemaps and @types/google.maps installed. Can you check that? And if removing one of the two manually works

image i have only one type removing both from the photo is not fixing it

my local workaround is to comment it image but if remove the typeof image or remove the MarkerOptions image

it compiles

antoniobuyukluev commented 3 months ago

@Haroenv image i think this is the reason

Haroenv commented 3 months ago

Thanks, I believe the changes in https://github.com/algolia/instantsearch/pull/6319 will fix the issue then. Do you mind using the version that codesandbox will provide in the PR locally and see if that all works? thanks!