algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.59k stars 503 forks source link

chore(examples): set instantsearchjs monorepo version in vue examples #6257

Closed dhayab closed 5 days ago

dhayab commented 5 days ago

Summary

It seems during last release the vue examples were not provided the right version for instantsearch.js, making the package an actual dependency instead of being linked from the monorepo.

codesandbox-ci[bot] commented 5 days ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a2ccda8a1abe562c741439a420b657df8b61e9f:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration
dhayab commented 5 days ago

ah yes that's because I didn't want to trigger a vue release but didn't realize this would have this effect. Won't we need to remove InstantSearch.js from the lock file now or was it never added?

It was not added or at least not versioned. I noticed when it showed a diff in my project.

Haroenv commented 5 days ago

yes, the last version had to be done manually since only a chore happened but I still wanted to release it :)