search

algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.73k stars 523 forks source link

Trouble building instantsearch.js from source #6301

Open Janik-Haag opened 3 months ago

Janik-Haag commented 3 months ago

🐛 Current behavior

When trying to build instantsearch.js from source, I get a different and broken result compared to the one located at https://cdn.jsdelivr.net/npm/instantsearch.js@4

image (diff produced with delta)

🔍 Steps to reproduce

git clone git@github.com:algolia/instantsearch.git
cd instantsearch/
yarn install
cd packages/instantsearch.js
yarn build:umd
wget https://cdn.jsdelivr.net/npm/instantsearch.js@4
diff instantsearch.js@4 dist/instantsearch.production.min.js

(the reproduction link is empty* because it shouldn't be relevant for this bug)

Live reproduction

https://example.com/

💭 Expected behavior

I'd expect to get the same output, or at least a working version. I also tried building with the latest instantsearch.js tag, but that produced the same non working result.

Package version

gituhub.com/algolia/instantsearch.git/master

Operating system

Linux-NixOS 24.05

Browser

Mozilla Firefox 128.0.2

Code of Conduct

Haroenv commented 3 months ago

I can't retry this locally, when you did your install, did it build instantsearch-ui-components as well? normally the install should trigger that. There's been a release since your issue and it also worked fine (no require of instantsearch-ui-components). Have you made any changes before you built?