fix(client): ensure client.search is bound

algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.

https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/

MIT License

3.73k stars 525 forks source link

fix(client): ensure client.search is bound #6352

Closed Haroenv closed 2 months ago

Haroenv commented 2 months ago

Summary

in 5.2.5 of algoliasearch, a change in the code is made, and client.search needs to be called with the correct this, which isn't the case if you say const search = client.search

Result

fixes #6350 fixes algolia/algoliasearch-client-javascript#1549

possibly also solves #6348, to investigate afterwards

codesandbox-ci[bot] commented 2 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c1c4ccf37bbf285624b1b3eaf293223dbc2d13b:

Sandbox	Source
example-instantsearch-getting-started	Configuration
example-react-instantsearch-getting-started	Configuration
example-react-instantsearch-next-app-dir-example	Configuration
example-react-instantsearch-next-routing-example	Configuration
example-vue-instantsearch-getting-started	Configuration