algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.73k stars 526 forks source link

fix(configure): ignore data attributes #6380

Open Haroenv opened 1 month ago

Haroenv commented 1 month ago

Summary

ignore data attributes in configure

Result

fixes https://github.com/getsentry/sentry-javascript/issues/12720#issuecomment-2396247718

I'm not yet convinced this is the right approach for all cases (may cause a slowdown possibly, although we already were spreading the props). Alternatively this could be in setQueryParameter or similar possibly, but would make that function more expensive.

In the mean time, anyone using the sentry plugin can use this patch

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 393c969f36865aeaa7515bae65cd6a705889794e:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration
JonasBa commented 1 month ago

Thank you @Haroenv ❤️