search

algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/
MIT License
3.73k stars 526 forks source link

fix(next-app-router): remove search.dispose #6406

Closed aymeric-giraudet closed 1 month ago

aymeric-giraudet commented 1 month ago

Summary

Fixes #6393

Thought this might help in mitigating memory leaks but it doesn't seem to do anything. So instead of fixing the error we night as well just remove the dispose call.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e768c576e94e987adaa4d29bee1645a04ace956:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration