Documentation Wrong for Instant Scroll Demo

mmorris8 commented 2 weeks ago

🐛 Current behavior

https://www.algolia.com/doc/guides/building-search-ui/ui-and-ux-patterns/infinite-scroll/react/

hits is deprecated. The code flat out doesn't work if you copy it into a project. When was this last tested???

🔍 Steps to reproduce

Go to https://codesandbox.io/p/devbox/muddy-brook-nbdfm?file=%2Findex.html and try to build it. Doesn't work.

Live reproduction

https://codesandbox.io/p/devbox/muddy-brook-nbdfm?file=%2Findex.html

💭 Expected behavior

The demo above, linked from the page, won't even build. Again, when was the last time this was tested???

Package version

Irrelevant - Online Documentation is wrong.

Operating system

OSX Sequoia

Browser

Edge Latest

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Haroenv commented 2 weeks ago

What do you mean it doesn't build? the example works for me perfectly fine. hits indeed should be changed to items, but for now both keys still work.

Build also seems to work:

Haroenv commented 2 weeks ago

I've made a pull request in the documentation to fix the hits that was still documented to use items like in the rest of the document

This issue is closed now because the documentation is updated. If you have more questions please continue

algolia / instantsearch