fix(instantsearch.js): prevent authenticated token being set as the `userToken`

algolia / instantsearch

⚡️ Libraries for building performant and instant search and recommend experiences with Algolia. Compatible with JavaScript, TypeScript, React and Vue.

https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/js/

MIT License

3.73k stars 525 forks source link

fix(instantsearch.js): prevent authenticated token being set as the `userToken` #6443

Open shaejaz opened 3 days ago

shaejaz commented 3 days ago

Summary The authenticated user token from insights should no longer be used as the userToken for the search API. This PR removes all listeners and usage of authenticatedUserToken in the insights middleware.

FX-3159

codesandbox-ci[bot] commented 3 days ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Haroenv commented 2 days ago

@shaejaz, best not to merge this right now yet as we may be needing a hotfix during code freeze and then I'd rather not have this change in it yet

shaejaz commented 2 days ago

@Haroenv makes sense 👍. Should I label this with 'do not merge' ?