search

algolia / jekyll-algolia

Add fast and relevant search to your Jekyll site
https://community.algolia.com/jekyll-algolia/
MIT License
214 stars 35 forks source link

[README] Incorrect Coverage Status #104

Closed ashmaroli closed 5 years ago

ashmaroli commented 5 years ago

The README is currently displaying incorrect Coverage status for the develop branch:

coverage develop

While the actual status is:

Coverage Status

pixelastic commented 5 years ago

Thanks for noticing that. I wanted to have two badges, one for master and one for develop on the readme. Coveralls doesn't allow customising the text of the badges AFAIK, so I uses shields.io as a proxy for that.

The API endpoint I'm using on coveralls.io is https://coveralls.io/github/algolia/jekyll-algolia.json?branch=develop, but it seems to be stuck for some reason on an old build entry (one that was coming from a PR actually).

I'm going to use the badge you linked, this seems more reliable.

ashmaroli commented 5 years ago

I'm going to use the badge you linked, this seems more reliable.

That was the badge recommended by https://coveralls.io/github/algolia/jekyll-algolia

pixelastic commented 5 years ago

✔ Done

image

I removed the double master/develop coverage. I'd rather display less information but keep them accurate than too much and inaccurate :)