Closed Haroenv closed 5 years ago
@pixelastic I chose to keep false
as the value on purpose, since that's what I chose in the configuration file. Do you think it makes more sense to have it as "empty hash" everywhere then?
@Haroenv I appreciate this project is no longer actively maintained but is there any way we can get this PR merged? It would be a great help :)
You can run from this branch. Sorry that I haven’t merged this, I don’t actively use Jekyll. I’ll take a look if I can finish these suggestions in a bit.
Totally get it, thanks in any case! I've been running from this branch but other software, like my host's server for example, can't run from branches and it's causing a lot of manual work. But I get the delay, all good. Just wanted to see if I could bump it a bit ;)
@EdenKupe, I've just applied the feedback I received. Can you test it on your side if this still works fully as expected?
Thank you so much for your work guys. I'll test this ASAP and let you know if the issue is resolved.
It's working, thanks so much guys! I like the warning message as well :)
Awesome to hear
fixes #34
New config value for
settings
:false
. In this case the settings from the dashboard won't be overridden.