algolia / laravel-scout-settings

DEPRECATED: Use of this repository is deprecated. Please use Scout Extended - https://github.com/algolia/scout-extended instead.
MIT License
23 stars 12 forks source link

Expanded tests #22

Closed qrazi closed 6 years ago

qrazi commented 6 years ago
qrazi commented 6 years ago

Closed this as I just realized the tests describe an invalid situation. This is relating to the replicas in the settings file. The name of the index as described in the replica is used for both getting the json file and for the actual index name in Algolia. Since my PR's were made for the purpose of having settings files committed in git and used across different environments with each their own index on Algolia, the settings files should not contain the prefix. However, when communicating with Algolia, the prefix should be added. The tests in this PR were not asserting that, so therefor I am closing this PR.