facetFilters is typed incorrectly

[kanehara]

🐛 Bug description

facetFilters is typed as readonly facetFilters?: string | readonly string[] | ReadonlyArray<readonly string[]>. This does not allow for a combination of AND / OR queries like so: facetFilters: ['filter1', ['filter1', 'filter2']]

🔍 Bug reproduction

1. Pass ['filter1', ['filter2', 'filter3']] into facetFilters arg
2. Get TS error

💭 Expected behavior

facetFilters should be typed as string | (string | string[])[]

🖥 Screenshots

Environment

• OS: macOS
• Browser: React Native
• Version: ^0.67.3

Additional context

[Haroenv]

Which facetFilters type is it you use?

[kanehara]

What do you mean? I'd like to apply an AND filter in conjunction with an OR filter. This works against the Algolia API but it isn't typed as being supported.

[Haroenv]

Sorry, I meant which code are you running? FacetFilters is defined in many places and I'm not sure which one is incorrect.

Also note that if you're using other widgets like RefinementList, they already use the facetFilters key and will override a parameter set by configure (or maybe get confused by it). If you want to set a standalone filter that doesn't get touched by any other InstantSearch code, filters is the best choice.

I'm still interested in knowing which code has that type, thanks!

[FabienMotte]

Hey!

We're doing a round of cleanup before migrating this repository to the new InstantSearch monorepo. This issue seems not to have generated much activity lately, so we're going to close it. Feel free to reopen it if you still have the type error.

We recommend anyone who is currently using React InstantSearch v6 to migrate to Hooks.