Nexjts SSR broken functionality with reactStrictMode enabled

[abusada]

🐛 Bug description

I'm following this guide trying to achieve server side rendering with nextjs and react-instantsearch-hooks.

once i wrap my code with InstantSearchSSRProvider, search functionality simple stops working,

Live reproduction:

https://codesandbox.io/s/hungry-stitch-b070o2?file=/pages/index.tsx:990-1014

🔍 Bug reproduction

Steps to reproduce the behavior:

1. Go to the provided sandbox: https://codesandbox.io/s/hungry-stitch-b070o2?file=/pages/index.tsx:990-1014
2. Try using the search box

💭 Expected behavior

Expect search to work and hits to update, notice how in the withour-ssr page the search functionality is working properly.

Environment

• React InstantSearch Hooks version: [6.29.0]
• React version: [18.2.0]
• Nextjs version [12.1.6]

please note the following configs in next.config.js:

module.exports = {
  reactStrictMode: true,
  swcMinify: true
};

update setting reactStrictMode to false fixes the issue, here is a fork of the above sandbox with strict mode turned off: https://codesandbox.io/s/lucid-cache-n7h0no?file=/next.config.js:19-45

[Haroenv]

There's indeed an issue with strict mode in server side rendering we haven't yet been able to pinpoint (the destroy method is called in the wrong order, and all state is reset, including refinements).

For now disabling strict mode in server side rendering is a workaround

[abusada]

Could you possibly point me to the code where you suspect the issue is happening? perhaps i could be of help!

[Haroenv]

There's some tests:

• https://github.com/algolia/react-instantsearch/pull/3518/files#diff-7accb274a0dfc2e4d20af5c09f1c9b6f800efaedcc568ffa1fd06dc5f8de55eeR160
• https://github.com/algolia/react-instantsearch/pull/3518/files#diff-e64eff9c1a1f08e5af58847734df1f2a89ae5ec7cae42f9c0d644c0b8c64be6fR382
• https://github.com/algolia/react-instantsearch/blob/89e5db61081fd1581c7ac98a5b788ebfed85c9ff/packages/react-instantsearch-hooks/src/lib/useInstantSearchApi.ts#L67 -> this should be called only on a timeout, as in useWidget

Also there's a more complex part where widgets get added more than once in hydration, but that might not be the cause of the issue

[francoischalifour]

This issue may be addressed in v6.30.2. Could you please upgrade and let us know how it goes?

[FabienMotte]

@kanehara Did the fix mentioned by @francoischalifour fixed your issue?

We're doing a round of cleanup before migrating this repository to the new InstantSearch monorepo. This issue seems not to have generated much activity lately, so we're going to close it, feel free to reopen if needed.