algolia / react-instantsearch

⚡️ Lightning-fast search for React and React Native applications, by Algolia.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/react/
MIT License
1.97k stars 386 forks source link

fix(hooks): type of DynamicWidgets props #3566

Closed Haroenv closed 2 years ago

Haroenv commented 2 years ago

Summary

instead of having the type correctly match which types are not allowed, there was an allow-list that was missing members. This is now fixed by going to a disallow-list of InstantSearch.js props that aren't needed

Result

fixes #3563

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d1ae52d81c0c3508aa0bce2853fc5e4d46f165d:

Sandbox Source
algolia/create-instantsearch-app Configuration
hooks-example Configuration
algolia react hooks Issue #3563
netlify[bot] commented 2 years ago

Deploy Preview for react-instantsearch ready!

Name Link
Latest commit 5d1ae52d81c0c3508aa0bce2853fc5e4d46f165d
Latest deploy log https://app.netlify.com/sites/react-instantsearch/deploys/62d51ef319a6c80008575561
Deploy Preview https://deploy-preview-3566--react-instantsearch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.