Closed DB-Alex closed 1 year ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 9e621529513d3149a64b4cd2ab0731f8e19d8409:
Sandbox | Source |
---|---|
react-instantsearch-app | Configuration |
hooks-example | Configuration |
Name | Link |
---|---|
Latest commit | 9e621529513d3149a64b4cd2ab0731f8e19d8409 |
Latest deploy log | https://app.netlify.com/sites/react-instantsearch/deploys/63234d89ce2ac70008bbccf2 |
Deploy Preview | https://deploy-preview-3626--react-instantsearch.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
sorry, but this causes https://github.com/webpack/webpack/issues/13865 to reappear. This does indeed give the "critical dependency", but it's actually on purpose as webpack has a bug and doesn't process conditional imports correctly
When renderToString is passed as an argument, this code path can be bypassed, and the error no longer happens. Thanks for your contribution!
…ency is an expression
Use a static dependency import for react-dom using the same code as next.js:
https://github.com/vercel/next.js/blob/6108f10799b46bc0ef97373c913e23714e135942/packages/next/server/render.tsx#L92
Summary
Result