algolia / react-instantsearch

⚡️ Lightning-fast search for React and React Native applications, by Algolia.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/react/
MIT License
1.97k stars 386 forks source link

feat(rish): translations for widgets #3638

Closed aymeric-giraudet closed 1 year ago

aymeric-giraudet commented 1 year ago

FX-1708

Summary

Result

Added tests to each widget to check if the translation is taken into account, used mostly getBy* rather than snapshots to create less noise in tests

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a07ed762a3480943939f3d9d8dd73949df21fb3:

Sandbox Source
react-instantsearch-app Configuration
hooks-example Configuration
netlify[bot] commented 1 year ago

Deploy Preview for react-instantsearch ready!

Name Link
Latest commit 2a07ed762a3480943939f3d9d8dd73949df21fb3
Latest deploy log https://app.netlify.com/sites/react-instantsearch/deploys/63355d5af733f000082c4083
Deploy Preview https://deploy-preview-3638--react-instantsearch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

aymeric-giraudet commented 1 year ago

Thanks @Haroenv ! It matches RFC except for showMore which I made into two labels rather than a function, there's a little discussion further up :D