algolia / react-instantsearch

โšก๏ธ Lightning-fast search for React and React Native applications, by Algolia.
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/react/
MIT License
1.97k stars 386 forks source link

feat(PoweredBy): update component logo #3661

Closed FabienMotte closed 1 year ago

FabienMotte commented 1 year ago

Summary

This PR updates the SVG of the <PoweredBy> widget component for react-instantsearch-dom and react-instantsearch-hooks-web and test snapshots.

codesandbox-ci[bot] commented 1 year ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 490b6cc7ba9c69897f6d8850d0aae3878fff0ee6:

Sandbox Source
react-instantsearch-app Configuration
hooks-example Configuration
netlify[bot] commented 1 year ago

Deploy Preview for react-instantsearch ready!

Name Link
Latest commit ba35e8e123098c0892e36087bfd226d1e46e1e67
Latest deploy log https://app.netlify.com/sites/react-instantsearch/deploys/63527ac4074bb80008615865
Deploy Preview https://deploy-preview-3661--react-instantsearch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for react-instantsearch ready!

Name Link
Latest commit 490b6cc7ba9c69897f6d8850d0aae3878fff0ee6
Latest deploy log https://app.netlify.com/sites/react-instantsearch/deploys/6357a5a0e38243000987bffa
Deploy Preview https://deploy-preview-3661--react-instantsearch.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sarahdayan commented 1 year ago

I see a missing space between the text and logo on React InstantSearch v6 (sandbox).

Capture dโ€™eฬcran 2022-10-21 aฬ€ 13 09 25

FabienMotte commented 1 year ago

I see a missing space between the text and logo on React InstantSearch v6 (sandbox).

Capture dโ€™eฬcran 2022-10-21 aฬ€ 13 09 25

@sarahdayan It looks like we have a margin-left: 0.3rem on RIS Storybook but I'm not sure where that's coming from

image
sarahdayan commented 1 year ago

@FabienMotte It's from the Algolia theme while the sandbox uses the Satellite theme.

FabienMotte commented 1 year ago

@sarahdayan Oh I see, so we had the issue before: https://codesandbox.io/s/react-instantsearch-app-forked-xyf9lu How do you think we should solve this?

sarahdayan commented 1 year ago

@FabienMotte Since the issue was already here, we can fix it separately.

Let's make sure we constrain the size of the SVG in this PR, then feel free to open another one to add the margin (can be done after this one is merged).

Haroenv commented 1 year ago

looks like the examples test snapshot needs to be updated: https://app.circleci.com/pipelines/github/algolia/react-instantsearch/3384/workflows/73addfe9-b508-4795-9235-d40303bc5934/jobs/58582

FabienMotte commented 1 year ago

@Haroenv I did update them but forgot to build before, doing it right now