Closed FabienMotte closed 1 year ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 490b6cc7ba9c69897f6d8850d0aae3878fff0ee6:
Sandbox | Source |
---|---|
react-instantsearch-app | Configuration |
hooks-example | Configuration |
Name | Link |
---|---|
Latest commit | ba35e8e123098c0892e36087bfd226d1e46e1e67 |
Latest deploy log | https://app.netlify.com/sites/react-instantsearch/deploys/63527ac4074bb80008615865 |
Deploy Preview | https://deploy-preview-3661--react-instantsearch.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Name | Link |
---|---|
Latest commit | 490b6cc7ba9c69897f6d8850d0aae3878fff0ee6 |
Latest deploy log | https://app.netlify.com/sites/react-instantsearch/deploys/6357a5a0e38243000987bffa |
Deploy Preview | https://deploy-preview-3661--react-instantsearch.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
I see a missing space between the text and logo on React InstantSearch v6 (sandbox).
I see a missing space between the text and logo on React InstantSearch v6 (sandbox).
@sarahdayan It looks like we have a margin-left: 0.3rem
on RIS Storybook but I'm not sure where that's coming from
@FabienMotte It's from the Algolia theme while the sandbox uses the Satellite theme.
@sarahdayan Oh I see, so we had the issue before: https://codesandbox.io/s/react-instantsearch-app-forked-xyf9lu How do you think we should solve this?
@FabienMotte Since the issue was already here, we can fix it separately.
Let's make sure we constrain the size of the SVG in this PR, then feel free to open another one to add the margin (can be done after this one is merged).
looks like the examples test snapshot needs to be updated: https://app.circleci.com/pipelines/github/algolia/react-instantsearch/3384/workflows/73addfe9-b508-4795-9235-d40303bc5934/jobs/58582
@Haroenv I did update them but forgot to build before, doing it right now
Summary
This PR updates the SVG of the
<PoweredBy>
widget component forreact-instantsearch-dom
andreact-instantsearch-hooks-web
and test snapshots.