search

algolia / scout-extended

Scout Extended: The Full Power of Algolia in Laravel
https://www.algolia.com/doc/framework-integration/laravel/getting-started/introduction-to-scout-extended/
MIT License
397 stars 84 forks source link

PHP 8.0 Support #256

Closed Nielsvanpach closed 3 years ago

Nielsvanpach commented 3 years ago
Q A
Bug fix? no
New feature? yes
BC breaks? no
Related Issue /
Need Doc update no

Describe your change

Provide support on PHP 8.0. I'll keep this PR in Draft until all dependencies can handle PHP 8.0

Waiting for:

Nielsvanpach commented 3 years ago

Hi @chloelbn, Some tests are failing over an API key. Can any of you help me on that one ?

Algolia\AlgoliaSearch\Exceptions\BadRequestException: Invalid Application-ID or API key

DevinCodes commented 3 years ago

Hi @Nielsvanpach, thank you for this PR!

I've tried to rerun the test to see if the error is still there. When I do this, the tests still fail, but I get another error. This leads me to believe your initial errors had something to do with CircleCI permissions, I'll try to make some time to look into that. The new error is this: Error: Call to undefined method Tests\Features\WhereQueriesTest::getAnnotations(). You can check the trace in CircleCI to debug.

Nielsvanpach commented 3 years ago

The initial error still occurs when I run the actions, @DevinCodes . Could you or someone of the Algolia team look into this? It would really be great to have PHP 8 support on the Algolia libraries, as this is the last blocking dependency for a lot of packages and projects.

Algolia\AlgoliaSearch\Exceptions\BadRequestException: Invalid Application-ID or API key
DevinCodes commented 3 years ago

I'll try to take a look at the errors early this week, @Nielsvanpach ! I'll also discuss with the team to see how we can move PHP8 compatibility forward as soon as possible.

In the meanwhile, thank you for the patience and for your contribution. I'll let you know when I learn more!

DevinCodes commented 3 years ago

Just a quick update: I've been trying to fix the error in the CI that keeps showing up, but I think there's an issue with the API key dealer. I'll have to dig deeper into that to get this fixed. Until that time, I'll manually run the test suite so that we're sure the tests pass once the API client supports PHP8.

Regarding PHP8 support, we're discussing internally how we can best tackle this, I hope we can give you an update soon. Thanks again for your patience.

Nielsvanpach commented 3 years ago

@DevinCodes last conflicts seem to be fixed. Can you run the tests again?

asivaneswaran commented 3 years ago

@DevinCodes @Nielsvanpach Any updates on when this is going to go through?

Nielsvanpach commented 3 years ago

No updates, we have to wait for Algolia on this one. But let them enjoy their holiday break first :-)

lahivee commented 3 years ago

Thanks to Spatie helping out Algolia updating their products

DevinCodes commented 3 years ago

Sorry for the delay, I've been vacationing for the last 2 weeks. I'll run the test suite, if all is good I think we're good to go! Thank you so much for your help on this @Nielsvanpach ! 🙇

michavie commented 3 years ago

thank you & happy new year!

lahivee commented 3 years ago

Thank you @DevinCodes , please also release this please

DevinCodes commented 3 years ago

@lahivee It's released in v1.11.0. It's available on Packagist, and I just drafted a release on GitHub:

lahivee commented 3 years ago

@DevinCodes thank you, I appreciate it!