algolia / scout-extended

Scout Extended: The Full Power of Algolia in Laravel
https://www.algolia.com/doc/framework-integration/laravel/getting-started/introduction-to-scout-extended/
MIT License
395 stars 85 forks source link

fix: circumvent queue when using aggregators #287

Closed DevinCodes closed 2 years ago

DevinCodes commented 2 years ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #282

Describe your change

This PR adds a change to circumvent the queue when using aggregators.

What problem is this fixing?

See #282

DevinCodes commented 2 years ago

@damcou Could you review this PR when you have some spare time, please? 😄

JayBizzle commented 2 years ago

On Monday we are going to pull this fix into our production environment and run it for a couple of days and see how it copes. Will report back if this hasn't been merged by then 👍

JayBizzle commented 2 years ago

We now have this PR running in our production environment.

Initial tests show that everything is running great, but we are going to leave it a few days and report back 👍🏻

JayBizzle commented 2 years ago

Been running this code now for 5 days with no reported issues. I'd say it is good to go 👍🏻

DevinCodes commented 2 years ago

That's awesome, thank you for reporting back @JayBizzle !

I'll reach out to @damcou for PR approval so we can release this this week 🙂

DevinCodes commented 2 years ago

@JayBizzle This is available in v2.0.2 which was just released! I'm releasing a patch for v1 in a bit (see #303)

JayBizzle commented 2 years ago

Brilliant, thank you 👍🏻

jackdaniel9 commented 2 years ago

Error again with 2.0.2 : Model not defined in aggregator.

if ($this->model === null) { throw new ModelNotDefinedInAggregatorException(); }

Controller:

Product::find($id)->delete();

bakerkretzmar commented 2 years ago

@jackdaniel9 likely related to #305