search

algolia / scout-extended

Scout Extended: The Full Power of Algolia in Laravel
https://www.algolia.com/doc/framework-integration/laravel/getting-started/introduction-to-scout-extended/
MIT License
393 stars 85 forks source link

chore: remove `final` keyword from classes #317

Closed DevinCodes closed 1 year ago

DevinCodes commented 1 year ago
Q A
Bug fix? no
New feature? no
BC breaks? no

Describe your change

This removes the final keyword from all class definitions.

What problem is this fixing?

Currently, it's impossible for users to extend the behavior of Scout Extended due to the final classes. Removing this keyword allows them to customise or replace the implementation of the class with something custom.

stevenmaguire commented 1 year ago

Is there an expectation for when this will make it into an upcoming release?

DevinCodes commented 1 year ago

Yes, I'm planning on creating a release for this today! Merging this already in preparation of that