algolia / vue-instantsearch

👀 Algolia components for building search UIs with Vue.js
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/vue
MIT License
854 stars 157 forks source link

fix(ssr): use dedicated instance per render #1115

Closed Haroenv closed 1 year ago

Haroenv commented 2 years ago

fixes algolia/instantsearch#5387

We use the same InstantSearch instance for every call of createServerRootMixin, but that means we start multiple times, without destroying, causing memory leaks.

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c0e36fbe45ad2cdf0eea38b1f1574a3283855c3:

Sandbox Source
vue-instantsearch-e-commerce Configuration
Haroenv commented 1 year ago

I'll close this for now, as it causes some relevant issues in the tests. They might be fixable, but as the problem doesn't come up often, I'll leave it as-is for now, to avoid disturbing otherwise working implementations