search

algolia / vue-instantsearch

👀 Algolia components for building search UIs with Vue.js
https://www.algolia.com/doc/guides/building-search-ui/what-is-instantsearch/vue
MIT License
854 stars 157 forks source link

add page class for "page" item #1129

Closed ymc-sise closed 2 years ago

ymc-sise commented 2 years ago

https://github.com/algolia/vue-instantsearch/issues/1128

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb0dec3a8a62bbb081e9165048097ffe07606975:

Sandbox Source
vue-instantsearch-e-commerce Configuration
Haroenv commented 2 years ago

This seems correct, although the tests need to be updated to take the new class in account. Are you able to run it locally?

ymc-sise commented 2 years ago

@Haroenv Unfortunately not. Can you edit the PR by yourself?

ymc-sise commented 2 years ago

I added the class to the snapshot file. Maybe the tests are correct now.

ymc-sise commented 2 years ago

Ok, I got it:

yarn test

PASS src/components/tests/Pagination.js (11.345s)

Seems to pass. But there is no specific test for matching ais-Pagination-item--page either...