search

algolia / youtube-captions-scraper

Fetch youtube user submitted or fallback to auto-generated captions
249 stars 67 forks source link

fix: remove font tags #1

Closed Meschreiber closed 6 years ago

Meschreiber commented 6 years ago

When we were using the package we noticed a lot of captions like this: backup<font color="#CCCCCC"> ran successfully and that bit is</font>

My regex is terrible, feel free to prettify

iam4x commented 6 years ago

Nice thanks, I'll be happy to help you for the regex. What is the videoId you had the issue?

Meschreiber commented 6 years ago

It happened with all or almost all actually

image

iam4x commented 6 years ago

This might be a bigger issue, we should remove any html tags. Can you try to use https://www.npmjs.com/package/striptags?

-- Maxime Janton Software Engineer +33 6 81 82 00 12

On 23 Nov 2017 at 00:55 +0100, Meschreiber notifications@github.com, wrote:

It happened with all or almost all actually — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

utay commented 6 years ago

You pushed your package-lock.json @Meschreiber haha Otherwise LGTM! 👍

Meschreiber commented 6 years ago

ugh, so embarrassing :P