search

algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 51 forks source link

Potential bug in pdf__pypdf2.py #110

Closed JulienPalard closed 4 years ago

JulienPalard commented 4 years ago

In:

if page_id == -1:
    preview_path = "{path}{file_name}{extension}".format(
        file_name=preview_name, path=cache_path, extension=extension
    )
else:
    preview_path = "{path}{file_name}{extension}".format(
        file_name=preview_name, path=cache_path, page_id=page_id, extension=extension
    )

It's strange that page_id is given but unused. cc @lebouquetin

inkhey commented 4 years ago

fixed by #126 : page number is already found in filename.