search

algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 51 forks source link

Adds cairosvg as SVG preview builder #128

Closed frague59 closed 4 years ago

frague59 commented 4 years ago

Warning ! Do not merge: no clean...

frague59 commented 4 years ago
frague59 commented 4 years ago

Seems clean:

frague59 commented 4 years ago

Might be merge-able...

frague59 commented 4 years ago

OK for docs

inkhey commented 4 years ago

@frague59 tests are broken due to missing cairosvg in setup.py

inkhey commented 4 years ago

@frague59 Test failed because code try to use inkscape builder instead of cairosvg one.

lebouquetin commented 4 years ago

@frague59 @inkhey I talked to @liZe (cairosvg author); he confirmed that both inkscape and cairosvg might be usefull because there is no better implementation of SVG (some stuff will be better in inkscape while others will be better in cairosvg)

I suggest... I don't know exactly but we should keep both. I think tests must access directly to builder, not get it from manager.

liZe commented 4 years ago

Hey everybody,

Thanks a lot for using CairoSVG!

CairoSVG and Inkscape are very different SVG renderers. Using a simple Python library is probably cleaner than relying on software with a graphical interface, but both have their pros and cons.

You can also take a look at librsvg (GNOME's default SVG renderer). It's widely used and already installed on many Linux desktops. I think that it supports less SVG features than CairoSVG and Inkscape, but I'm obviously not neutral about that :wink:.

Last but not least: during our discussion, I've forgot to say that the most advanced renderers for SVG are browsers. I don't know if it's easy (or even desirable, it's a huge dependency) to use them in preview-generator, but it should be possible.

inkhey commented 4 years ago

Hello @frague59 :wave: Thank for this feature. Could you allow us to modify you branch directly to help us release the feature sooner ? (see https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)

lebouquetin commented 4 years ago

@frague59 could you send me both your postal address and your tshirt size in order I send you the algoo tshirt ? lets send it to my professionnal email : damien dot accorsi arobase algoo dot fr