search

algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 50 forks source link

Repair Raw Preview on Imagemagick builder: ufraw-batch does no longer exists in Debian #154

Open JulienPalard opened 4 years ago

JulienPalard commented 4 years ago

see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=931725

inkhey commented 4 years ago

Thank for the feedback. We need to find a better way to deal with delegate feature of imagemagick. As ufraw-batch is removed in debian 11, support for raw file with imagemagick should probably be linked to another lib/external program. I think about libraw support but it seems added to imagemagick 7.* only (imagemagick 7 is not provided at all in debian now): https://github.com/ImageMagick/ImageMagick/commit/cefed48d4f78b71e2f6a3a15d0ba7f586570de56

mosi-kha commented 3 years ago

any activity in this issue?

inkhey commented 3 years ago

any activity in this issue?

Hello, There is no update for this issue.

I suggest you to either use a version of debian that always support ufraw like current stable buster or installing libraw + imagemagick 7 on debian and try it. preview_generator code is mostly transparent to this issue, it's more a debian issue related to raw support in imagemagick, that a preview_generator issue, so there should not be any change in code needed as far i know.

Let's us know if you find an interesting workaround (like using imagemagick 7 + libraw), we are interested in feedback.

inkhey commented 3 years ago

I suggest you to either use a version of debian that always support ufraw like current stable buster or installing libraw + imagemagick 7 on debian and try it. preview_generator code is mostly transparent to this issue, it's more a debian issue related to raw support in imagemagick, that a preview_generator issue, so there should not be any change in code needed as far i know.

in fact, there does exist code about ufraw-batch, it's only a check to enable/disable raw support: https://github.com/algoo/preview-generator/blob/8a0e6b3b079e5d4333e98e5bf03e32195a96d788/preview_generator/preview/builder/image__imconvert.py#L71 You may be able bypass it by removing the line or create a dummy ufraw-batch executable.

inkhey commented 3 years ago

Another solution to test is dcraw with imagemagick and latest debian.