algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 50 forks source link

Add basic image/heic support #172

Closed L3o-pold closed 4 years ago

L3o-pold commented 4 years ago

Todo:

L3o-pold commented 4 years ago

Is it possible to drop Python 3.5 support?

inkhey commented 4 years ago

Hello, thanks for your contribution to preview_generator.

Is it possible to drop Python 3.5 support?

Not now, we do use debian stretch, so we do need to keep python 3.5 support for preview_generator, but there is no requirement for heic support on python 3.5.

Can you try to make support for heic working only on python 3.6+ ? you can add pytest skipif (https://docs.pytest.org/en/latest/skipping.html#id1) and use check_dependencies method of builder to refuse autoloading of heic builder on python <3.6.

L3o-pold commented 4 years ago

@inkhey hi, yes thanks for your feedback. I'll have a look ASAP

L3o-pold commented 4 years ago

In fact, Imagick should be able to handle HEIC format without using an other python package.

L3o-pold commented 4 years ago

It should be OK now. If IM is built with HEIC support it works as expected.