algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 50 forks source link

Feat: Use modern an maintained library for pdf generation instead of pypdf2 #192

Closed inkhey closed 2 years ago

inkhey commented 4 years ago

We currently get many trouble with pypdf2:

This library is not properly maintained (now a new project pypdf4 exist) We should find a pdf library that can handle properly those use case and recreate a new pdf builder. Poppler seems the way to go : https://en.wikipedia.org/wiki/Poppler_(software) (used by libreoffice, evince, inkscape, etc...)

inkhey commented 4 years ago

Note: I see two alternative project for a modern and correctly maintenained pdf builder:

titusz commented 3 years ago

have a look at: https://github.com/pymupdf/PyMuPDF

inkhey commented 2 years ago

Another solution may be simply use poppler-utils : https://packages.debian.org/fr/bullseye/poppler-utils instead of python-poppler lib, this avoid license issues (poppler is gpl) and having weak connection has some benefit (seems easier to make timeout for example).

inkhey commented 2 years ago

fixed by the poppler based builder #275