search

algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 50 forks source link

Add support for GLTF export #195

Closed cromize closed 3 years ago

cromize commented 4 years ago

This PR:

  1. Fixes import issue for 3D vtk readers (newer version of vtk changed naming). I would consider freezing packages version.
  2. Adds support for vtk GLTF reader.
cromize commented 4 years ago

I added test for gltf. Gltf test is passing for python >= 3.6. It's failing on 3.5 because pypi is missing vtk9 package for linux (linux is only missing platform).

Travis seems to have problem getting vtk9 package from pypi on python3.8. I tried to trigger travis build couples times, but I had to pip install vtk manually to make it work.

It worked locally though when I tried it on same ubuntu vm.

inkhey commented 4 years ago

Thanks for you changes.

I added test for gltf. Gltf test is passing for python >= 3.6. It's failing on 3.5 because pypi is missing vtk9 package for linux (linux is only missing platform).

As far i see tests, most vtk features does work with new code on python 3.5, can you confirm that ? If i'm correct, i suggest to:

One other way will be dropping python 3.5 support but we do need to support it a bit longer.

Travis seems to have problem getting vtk9 package from pypi on python3.8. I tried to trigger travis build couples times, but I had to pip install vtk manually to make it work.

It worked locally though when I tried it on same ubuntu vm.

Curious. I don't think it's a big issue. just comment this where you force the install of vtk.

inkhey commented 3 years ago

@cromize , Your PR as been replaced by https://github.com/algoo/preview-generator/pull/240. It should be straightforward to merge it now. Just need to verify all is ok. We will merge this by squashing commits and keep you as co-contributor.