algoo / preview-generator

generates previews of files with cache management
https://pypi.org/project/preview-generator/
MIT License
228 stars 50 forks source link

GIFs Preview ? #201

Open celiamgtt opened 4 years ago

celiamgtt commented 4 years ago

It's not really interesting to have a GIF preview. The interesting thing about GIFs is that they're animated. I would expect GIFs stay animated.

Issue in the Tracim Project : https://github.com/tracim/tracim/issues/3460

Also Gif preview for video file make sense.

lebouquetin commented 4 years ago

you right @celiamgtt . Do you know if there is an issue on https://github.com/tracim/tracim?

There are two ways to fix this:

inkhey commented 4 years ago

I'm not sure we do not need a preview for gif. If the size (width/length) of the original file is too high, we can resize using css (is there a limit ?) but what should happened if the gif is a very big file ? Should we force the browser to load a big gif ? Is there any magic in the browser to load it gracefully like for video ?

Another solution may be to provide gif preview by resizing gif, there is already an issue about gif preview for video: https://github.com/algoo/preview-generator/issues/177

inkhey commented 4 years ago

It seems like the way to go to save bandwidth is converting gif to video : https://www.smashingmagazine.com/2018/11/gif-to-video/

celiamgtt commented 4 years ago

@lebouquetin Yes I created both issues as Philippe told me to do so but I forgot to link the 2 issues x)