fix: inkscape is optional. - Githubissues

algoo / preview-generator

generates previews of files with cache management

https://pypi.org/project/preview-generator/

MIT License

235 stars 51 forks source link

fix: inkscape is optional. #272

Closed grignards closed 3 years ago

grignards commented 3 years ago

The fix for #263 made inkscape mandatory unvolontarily.

PR Goal

Take care that a non-installed inkscape is a valid environment.

Implemented solution

Catch the exception raised by check_output when inkscape is not installed.

Checkpoints

[x] If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
[x] Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
[x] The PR or the original issue contains a short summary of the implemented solution.