Feat/192 poppler based pdf builder

[inkhey]

related to #192

PR Goal

Use Poppler-utils command line instead of Pypdf2 and qpdf to get proper pdf preview Goals are:

• Use maintained package used by other big projects (libreoffice, kde, gnome) to avoid the problem we do have with previous builder
• Use command line instead of Lib to avoid licence issue (poppler is gpl based)
• Performance improvement (bad performance are discovered here: https://github.com/tracim/tracim/issues/4955)
• Simplify code.
• Less preview issue related to library that is not able to deal with the pdf format complexity.

Implemented solution

• add poppler-utils based pdf builder.
• removing pypdf2-based builder and related dependencies.

Checkpoints

• [x] If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works
• [x] Automated tests covering the feature or the fix, have been written, deemed irrelevant (give the reason), or an issue has been created to implement the test (give the link)
• [x] The PR or the original issue contains a short summary of the implemented solution.

[raphj]

I don't have any opinion or particular insight on on this, I trust you to make the right call here.

Le 19/11/2021 à 15:28, inkhey a écrit :

@.**** commented on this pull request.

---

In preview_generator/preview/builder/pdf__poppler_utils.py https://github.com/algoo/preview-generator/pull/275#discussion_r753236559:

• TODO - G.M - 2021-10-21 - Reintroduce caching here ?

• lines = check_output(["pdfinfo", file_path], stderr=STDOUT, universal_newlines=True).split(
• "\n"
• )
• for line in lines:
• section, data = line.split(":", maxsplit=1)
• if section == "Pages":
• return int(data.strip())

• FIXME - G.M - 2021-10-21 - Better default case ?

• return 0

@grignards https://github.com/grignards @raphj https://github.com/raphj This code replace the old code that does use a cached file. I'm not really such we do really improve performance between running pdfinfo command line or opening a cached file that store the number of page provided a first time by pdfinfo. Did you think i should restore the previous behavior here or not ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/algoo/preview-generator/pull/275#pullrequestreview-811275435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5D7FN6EXMTFXKXPB6CHRDUMZNKLANCNFSM5GOLKV6A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.