algora-io / tv

Open source Twitch for developers
https://algora.tv
Other
1.07k stars 67 forks source link

feat(streaming): implement stream key management #66

Closed onyedikachi-david closed 2 months ago

onyedikachi-david commented 3 months ago

/claim #41 Fixes: #41

onyedikachi-david commented 2 months ago

image

zcesur commented 2 months ago

Getting this error:

[error] GenServer #PID<0.882.0> terminating
** (KeyError) key :stream_key not found in: %Membrane.RTMP.Messages.Connect{
  app: "live",
  tc_url: "rtmp://localhost:9006/live",
  flash_version: "FMLE/3.0 (compatible; FMSc/1.0)",
  swf_url: "rtmp://localhost:9006/live",
  fpad: nil,
  audio_codecs: nil,
  video_codecs: nil,
  video_function: nil,
  page_url: nil,
  object_encoding: nil,
  extra: %{"type" => "nonprivate"},
  tx_id: 1.0
}

Pretty sure it should be exposed in a param inside one of the validate_xyz handlers

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

zcesur commented 2 months ago

Resolved with another PR, thanks for attempting!