Terminate interrupted streams

algora-io / tv

Open source Twitch for developers

https://algora.tv

Other

1.07k stars 67 forks source link

Terminate interrupted streams #75

Closed Lirianer closed 2 months ago

Lirianer commented 2 months ago

Additions:

New Algora.Terminate GenServer:
- Looks for videos with duration 0 and is_live false
- Calls Algora.Library.terminate_stream with the video id
- Runs every 10 seconds
New Algora.Library.terminate_stream/1
- Gets video manifest
- Appends "#EXT-X-ENDLIST\n" if necessary
- Updates video duration
Note: With this changes Algora.Terminate should not get the same videos again as the duration is updated. Although if the duration is less than a second this could be a problem.

Im learning elixir so any suggestions/changes are appreciated.

/claim #69

Lirianer commented 2 months ago

I've done the changes you pointed out!

It's been a blast so far, although I do waste a lot of time thinking on whether something should be a new function or not and if im missing a better/more idiomatic way of doing things

zcesur commented 2 months ago

Awesome, thanks!

I converted case into with and moved get_duration up there so we handle any errors there as well (233a53d)

We can proceed to merge & reward once you sign our CLA

CLAassistant commented 2 months ago

All committers have signed the CLA.

zcesur commented 2 months ago

If you're on Twitter I'd love to tweet about you being our first contributor :)

Btw feel free to DM me any time or use the #contributing channel in our Discord for anything Algora/Elixir related

Lirianer commented 2 months ago

Sure! I'm @Lirianer_ on Twitter/X.

Thanks, just joined the discord!