Closed Lirianer closed 2 months ago
I've done the changes you pointed out!
It's been a blast so far, although I do waste a lot of time thinking on whether something should be a new function or not and if im missing a better/more idiomatic way of doing things
Awesome, thanks!
I converted case
into with
and moved get_duration
up there so we handle any errors there as well (233a53d)
We can proceed to merge & reward once you sign our CLA
If you're on Twitter I'd love to tweet about you being our first contributor :)
Btw feel free to DM me any time or use the #contributing channel in our Discord for anything Algora/Elixir related
Sure! I'm @Lirianer_ on Twitter/X.
Thanks, just joined the discord!
Additions:
New Algora.Terminate GenServer:
New Algora.Library.terminate_stream/1
Note: With this changes Algora.Terminate should not get the same videos again as the duration is updated. Although if the duration is less than a second this could be a problem.
Im learning elixir so any suggestions/changes are appreciated.
/claim #69