Closed kaf-lamed-beyt closed 1 month ago
Thanks for the PR @kaf-lamed-beyt! Works great overall, can merge it in once these are addressed
Smooth! Thanks for the feedback
hi @zcesur, please take a look. I added the onAutoplayFail()
callback too, lemme know if I'm on the right track, thanks!
I forgot to add .lexical to gitignore, git tracked it. I also tried deleting the file from this PR, but it seems that's not possible? because I can still see it here.
despite adding /.lexical to gitignore, and deleting it here, I can still see it being generated. What could be the issue?
Autoplay still doesn't work, there's a chance onAutoPlayFail
is not available in vanilla JS build of the player. Can you try and see if something like this works?
this.player.subscribe(({ autoPlayError }) => {
if (autoPlayError) {
this.player.muted = true;
this.player.play();
}
});
Not sure why .lexical got tracked. Did you try pushing a new commit with its deletion?
Okay. I'll try this.
About lexical... when I deleted the folder, and I went on with my stuff, it auto-generated it again. Perhaps, I'll remove the extension. Hopefully that fixes it.
This is awesome!!
@zcesur, could you review when you're free? Here's an overview of what I did though.
analytics
prefix?t
query param works as it should. PS:?t=1
is equivalent to10s
demo
Screencast from 05-09-2024 00:33:01.webm
Some issues I'm having
/claim #45